Button & Link Updates #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
shawnbot
reviewed
Oct 25, 2018
emplums
commented
Oct 25, 2018
src/Link.js
Outdated
| const hoverColor = style({ | ||
| prop: 'hoverColor', | ||
| cssProperty: 'color', | ||
| key: 'colors' | ||
| }) | ||
|
|
||
| const styledLink = styled('a')` | ||
| const Link = ({is: Tag, children, ...rest}) => { |
There was a problem hiding this comment.
I did this because I couldn't figure out how to pass a dynamic tag based on a prop to styled
Co-Authored-By: emplums <emplums@github.com>
emplums
commented
Oct 25, 2018
| @@ -32,6 +58,32 @@ exports[`Link renders without any props 1`] = ` | |||
| } | |||
|
|
|||
| <a | |||
| blacklist={ | |||
There was a problem hiding this comment.
@shawnbot do you know why this is happened and if it's okay or not? I think it has something to do with calling styled(Link) instead of styled('a') but I'm not positive 🤔
There was a problem hiding this comment.
I don't know, but I'm 90% sure it's a system-components thing. Maybe we could use clean-tag if we just want to keep those attributes out of the resulting DOM? 🤔
shawnbot
approved these changes
Oct 25, 2018
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
widthpropblockprop on ButtonButtonLink- users should use a<Link is='button'>for this use case. The model here should beButtonis a UI element that is styled like a button.Linkis a UI element that is styled like a link. You can change the tag as needed.Closes #312
Merge checklist