StyledOcticon/Octicon: Update the render func to use React.forwardRef()
#3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 74aa001 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
May 17, 2023
colebemis
approved these changes
May 17, 2023
jonrohan
approved these changes
May 17, 2023
This was referenced May 17, 2023
Merged
broccolinisoup
added a commit
that referenced
this pull request
Jun 16, 2023
…3408) * Revert "Refactor(ActionList): ActionList.Item should render content as a button if parent is not interactive. (#3284)" This reverts commit 08d7d5d. * Revert "Address ToggleSwitch a11y feedback (#3251)" This reverts commit 580f165. * Revert "Revert "Refactor FilteredActionList to address a11y violations and use new ActionList. (#3247)" (#3349)" This reverts commit a6b4169. * Revert "fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler by @gr2m (#3346)" This reverts commit 6304923. * Revert "Refactor FilteredActionList to address a11y violations and use new ActionList. (#3247)" This reverts commit e865e3e. * Revert "fix(ActionList): update to read from group context if selectionVariant is defined (#3269)" This reverts commit 21ec626. * Revert "Add back check for GroupContext in ActionList.Selection to fix issues introduced to github/github (#3267)" This reverts commit 332a1af. * Revert "Fix create-slots utils path (#3223)" This reverts commit f50997f. * Revert "Allow up to 4 levels of nesting for the NavList (#3343)" This reverts commit 786013e. * Revert "NavList: Fix group dividers (#3328)" This reverts commit 1fd6d32. * Revert "StyledOcticon/Octicon: Update the render func to use `React.forwardRef()` (#3293)" This reverts commit 027d214. * Revert "Rename component StyledOcticon to Octicon (#3148)" This reverts commit ac437bb. * Revert "Update PRC ActionList implementation to have similar semantics to PVC. (#2878)" This reverts commit 87883c3. * Update generated/components.json * Revert "Bump @primer/react-octicons to v19.0.1 (#3266)" This reverts commit 9532977. * Revert "Remove aria-hidden=true from spans with required asterisk (#3320)" This reverts commit 47b7ea0. * Rename component StyledOcticon to Octicon (#3148) * Rename component StyledOcticon to Octicon * Update generated/components.json * Create .changeset/swift-cows-rest.md * Fix snapshot * Add segments to progressbar (#3114) * Allow ProgressBar to either be given child segments or just a progress value. * Update ProgressBar docs. * Fix progress bar tests. * Create dry-weeks-compete.md * Fix errors from CI. * Rename ProgressBar.Segment to ProgressBar.Item. * Pass backgroundColor instead of bg to get away from system props, simplify children check in ProgressBar. * Updated snapshots. * Updated snapshots using --no-cache flag. * refactor(CircleOcticon): Move files to folder, add storybook and e2e tests. (#3119) * Reorganize CircleOcticon files, add story and e2e tests. * Add index file. * Update generated/components.json * refactor(CircleBadge): move files into folder, add e2e tests. (#3118) * Reorganize CircleBadge, add e2e tests. * Update generated/components.json * test(vrt): update snapshots * Update docs reference. --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Refactor(Popover): move files into folder, add storybook and e2e tests. (#3135) * Move files into folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * refactor(ButtonGroup): move files to folder. (#3117) * Reorganize ButtonGroup component and stories. * Update generated/components.json * Add e2e tests. * test(vrt): update snapshots * refactor(CircleBadge): move files into folder, add e2e tests. (#3118) * Reorganize CircleBadge, add e2e tests. * Update generated/components.json * test(vrt): update snapshots * Update docs reference. --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * replace createRef with useRef (#3124) * replace createRef with useRef * changeset * missed null * refactor(FilterList): add files to folder, add storybook and e2e tests. (#3122) * Reorganize FilterList files into folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Refactor(FilteredSearch): move files to folder, add storybook and e2e tests. (#3125) * Move files to folder, add storybook and e2e tests. * Add aria-label to TextInput, fix docs reference. * Update generated/components.json * test(vrt): update snapshots * replace createRef with useRef (#3124) * replace createRef with useRef * changeset * missed null * refactor(FilterList): add files to folder, add storybook and e2e tests. (#3122) * Reorganize FilterList files into folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Fix generated components. --------- Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> * Refactor(LabelGroup): add files to folder, add storybook and e2e tests. (#3131) * Move files to folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * test(e2e): update ActionMenu e2e test to remove custom contrast rules (#3130) * test(e2e): update ActionMenu e2e test to remove custom contrast rules * test(vrt): update snapshots * test: remove multiple sections test * test(e2e): restore rule exception for ActionMenu --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * NavList SSR: use useIsomorphicLayoutEffect instead of useLayoutEffect (#3127) * use useIsomorphicLayoutEffect * Create .changeset/fast-panthers-refuse.md --------- Co-authored-by: Josh Black <joshblack@github.com> * Bump @primer/primitives to `7.11.5` (#3120) * npm install @primer/primitives@7.11.5 * Updating`theme-preval` snapshots * Re-run ``` npm run build npm run test -- -u ``` So that /themePreval.test.ts.snap also gets the new timestamp * Update `theme-preval` snapshots docs * Create .changeset/old-falcons-learn.md * test(vrt): update snapshots --------- Co-authored-by: simurai <simurai@users.noreply.github.com> * Update RelativeTime stories (#3136) * Update RelativeTime stories * Update generated/components.json --------- Co-authored-by: colebemis <colebemis@users.noreply.github.com> * chore(deps-dev): bump @types/jest-axe from 3.5.3 to 3.5.5 (#3141) Bumps [@types/jest-axe](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest-axe) from 3.5.3 to 3.5.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest-axe) --- updated-dependencies: - dependency-name: "@types/jest-axe" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @rollup/plugin-typescript from 11.0.0 to 11.1.0 (#3138) Bumps [@rollup/plugin-typescript](https://github.com/rollup/plugins/tree/HEAD/packages/typescript) from 11.0.0 to 11.1.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/typescript/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v11.1.0/packages/typescript) --- updated-dependencies: - dependency-name: "@rollup/plugin-typescript" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump eslint-plugin-primer-react from 2.0.2 to 2.0.3 (#3140) * chore(deps-dev): bump eslint-plugin-primer-react from 2.0.2 to 2.0.3 Bumps [eslint-plugin-primer-react](https://github.com/primer/eslint-plugin-primer-react) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/primer/eslint-plugin-primer-react/releases) - [Changelog](https://github.com/primer/eslint-plugin-primer-react/blob/main/CHANGELOG.md) - [Commits](primer/eslint-plugin-primer-react@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: eslint-plugin-primer-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(eslint): remove unnecessary disable --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * chore(deps-dev): bump babel-plugin-styled-components from 2.0.2 to 2.1.1 (#3139) * chore(deps-dev): bump babel-plugin-styled-components from 2.0.2 to 2.1.1 Bumps [babel-plugin-styled-components](https://github.com/styled-components/babel-plugin-styled-components) from 2.0.2 to 2.1.1. - [Release notes](https://github.com/styled-components/babel-plugin-styled-components/releases) - [Commits](styled-components/babel-plugin-styled-components@v2.0.2...v2.1.1) --- updated-dependencies: - dependency-name: babel-plugin-styled-components dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * test(snapshots): update snapshots --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * chore(project): update project to use Node.js v18 LTS (#3133) * chore(project): update project to use Node.js v18 LTS * chore: add legacy openssl option for docs builds * chore: update devcontainer image --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Use SSR-compatible slot implementation in CheckboxGroup/RadioGroup (#3146) * Update slots for checkbox group and radio group * Update useSlot return type * Update exports test * Create .changeset/young-queens-notice.md * Update comment indentation * Add segments to progressbar (#3114) * Allow ProgressBar to either be given child segments or just a progress value. * Update ProgressBar docs. * Fix progress bar tests. * Create dry-weeks-compete.md * Fix errors from CI. * Rename ProgressBar.Segment to ProgressBar.Item. * Pass backgroundColor instead of bg to get away from system props, simplify children check in ProgressBar. * Updated snapshots. * Updated snapshots using --no-cache flag. * Update generated/components.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(project): move code of conduct under .github (#3145) Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Add npm workspaces structure to primer/react (#3074) * test(axe): default `color-contrast` check to false * chore: update generate script to not conditionally disable contrast checks * Create adr-015-npm-workspaces.md * docs: update adr * Update adr-015-npm-workspaces.md --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Update generated/components.json * change styled_octicon key * Update generated/components.json * Update generated/components.json * Update generated/components.json * Octicon folder * Fix package-lock * Fix imports * update path * Update generated/components.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: jonrohan <jonrohan@users.noreply.github.com> Co-authored-by: Jeremy Neal <radglob@github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josep Martins <josepmartins@github.com> * Allow up to 4 levels of nesting for the NavList (#3343) * allows up to 4 levels of nesting for the NavList * adds changeset * Update src/NavList/NavList.tsx Co-authored-by: Cole Bemis <colebemis@github.com> * updates snapshots --------- Co-authored-by: Cole Bemis <colebemis@github.com> * fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler by @gr2m (#3346) * fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler (#3163) * test: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler Failing test for #3162 * fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`ߴs `onSelect` handler * add storybook example: Delayed Menu Close * update docs * docs: changeset * Update changelog --------- Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> * Update generated/components.json --------- Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com> Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com> * Revert "PageLayout.Content should not use main landmark by default. (#3154)" This reverts commit fed1c57. * Revert "Update `PageLayout` docs around `<main>` usage (#3323)" This reverts commit e1904b2. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes> Co-authored-by: jonrohan <jonrohan@users.noreply.github.com> Co-authored-by: Jeremy Neal <radglob@github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josep Martins <josepmartins@github.com> Co-authored-by: Mike Perrotti <mperrotti@github.com> Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com> Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
radglob
added a commit
that referenced
this pull request
Jun 16, 2023
…3408) * Revert "Refactor(ActionList): ActionList.Item should render content as a button if parent is not interactive. (#3284)" This reverts commit 08d7d5d. * Revert "Address ToggleSwitch a11y feedback (#3251)" This reverts commit 580f165. * Revert "Revert "Refactor FilteredActionList to address a11y violations and use new ActionList. (#3247)" (#3349)" This reverts commit a6b4169. * Revert "fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler by @gr2m (#3346)" This reverts commit 6304923. * Revert "Refactor FilteredActionList to address a11y violations and use new ActionList. (#3247)" This reverts commit e865e3e. * Revert "fix(ActionList): update to read from group context if selectionVariant is defined (#3269)" This reverts commit 21ec626. * Revert "Add back check for GroupContext in ActionList.Selection to fix issues introduced to github/github (#3267)" This reverts commit 332a1af. * Revert "Fix create-slots utils path (#3223)" This reverts commit f50997f. * Revert "Allow up to 4 levels of nesting for the NavList (#3343)" This reverts commit 786013e. * Revert "NavList: Fix group dividers (#3328)" This reverts commit 1fd6d32. * Revert "StyledOcticon/Octicon: Update the render func to use `React.forwardRef()` (#3293)" This reverts commit 027d214. * Revert "Rename component StyledOcticon to Octicon (#3148)" This reverts commit ac437bb. * Revert "Update PRC ActionList implementation to have similar semantics to PVC. (#2878)" This reverts commit 87883c3. * Update generated/components.json * Revert "Bump @primer/react-octicons to v19.0.1 (#3266)" This reverts commit 9532977. * Revert "Remove aria-hidden=true from spans with required asterisk (#3320)" This reverts commit 47b7ea0. * Rename component StyledOcticon to Octicon (#3148) * Rename component StyledOcticon to Octicon * Update generated/components.json * Create .changeset/swift-cows-rest.md * Fix snapshot * Add segments to progressbar (#3114) * Allow ProgressBar to either be given child segments or just a progress value. * Update ProgressBar docs. * Fix progress bar tests. * Create dry-weeks-compete.md * Fix errors from CI. * Rename ProgressBar.Segment to ProgressBar.Item. * Pass backgroundColor instead of bg to get away from system props, simplify children check in ProgressBar. * Updated snapshots. * Updated snapshots using --no-cache flag. * refactor(CircleOcticon): Move files to folder, add storybook and e2e tests. (#3119) * Reorganize CircleOcticon files, add story and e2e tests. * Add index file. * Update generated/components.json * refactor(CircleBadge): move files into folder, add e2e tests. (#3118) * Reorganize CircleBadge, add e2e tests. * Update generated/components.json * test(vrt): update snapshots * Update docs reference. --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Refactor(Popover): move files into folder, add storybook and e2e tests. (#3135) * Move files into folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * refactor(ButtonGroup): move files to folder. (#3117) * Reorganize ButtonGroup component and stories. * Update generated/components.json * Add e2e tests. * test(vrt): update snapshots * refactor(CircleBadge): move files into folder, add e2e tests. (#3118) * Reorganize CircleBadge, add e2e tests. * Update generated/components.json * test(vrt): update snapshots * Update docs reference. --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * replace createRef with useRef (#3124) * replace createRef with useRef * changeset * missed null * refactor(FilterList): add files to folder, add storybook and e2e tests. (#3122) * Reorganize FilterList files into folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Refactor(FilteredSearch): move files to folder, add storybook and e2e tests. (#3125) * Move files to folder, add storybook and e2e tests. * Add aria-label to TextInput, fix docs reference. * Update generated/components.json * test(vrt): update snapshots * replace createRef with useRef (#3124) * replace createRef with useRef * changeset * missed null * refactor(FilterList): add files to folder, add storybook and e2e tests. (#3122) * Reorganize FilterList files into folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Fix generated components. --------- Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> * Refactor(LabelGroup): add files to folder, add storybook and e2e tests. (#3131) * Move files to folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * test(e2e): update ActionMenu e2e test to remove custom contrast rules (#3130) * test(e2e): update ActionMenu e2e test to remove custom contrast rules * test(vrt): update snapshots * test: remove multiple sections test * test(e2e): restore rule exception for ActionMenu --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * NavList SSR: use useIsomorphicLayoutEffect instead of useLayoutEffect (#3127) * use useIsomorphicLayoutEffect * Create .changeset/fast-panthers-refuse.md --------- Co-authored-by: Josh Black <joshblack@github.com> * Bump @primer/primitives to `7.11.5` (#3120) * npm install @primer/primitives@7.11.5 * Updating`theme-preval` snapshots * Re-run ``` npm run build npm run test -- -u ``` So that /themePreval.test.ts.snap also gets the new timestamp * Update `theme-preval` snapshots docs * Create .changeset/old-falcons-learn.md * test(vrt): update snapshots --------- Co-authored-by: simurai <simurai@users.noreply.github.com> * Update RelativeTime stories (#3136) * Update RelativeTime stories * Update generated/components.json --------- Co-authored-by: colebemis <colebemis@users.noreply.github.com> * chore(deps-dev): bump @types/jest-axe from 3.5.3 to 3.5.5 (#3141) Bumps [@types/jest-axe](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest-axe) from 3.5.3 to 3.5.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest-axe) --- updated-dependencies: - dependency-name: "@types/jest-axe" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @rollup/plugin-typescript from 11.0.0 to 11.1.0 (#3138) Bumps [@rollup/plugin-typescript](https://github.com/rollup/plugins/tree/HEAD/packages/typescript) from 11.0.0 to 11.1.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/typescript/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v11.1.0/packages/typescript) --- updated-dependencies: - dependency-name: "@rollup/plugin-typescript" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump eslint-plugin-primer-react from 2.0.2 to 2.0.3 (#3140) * chore(deps-dev): bump eslint-plugin-primer-react from 2.0.2 to 2.0.3 Bumps [eslint-plugin-primer-react](https://github.com/primer/eslint-plugin-primer-react) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/primer/eslint-plugin-primer-react/releases) - [Changelog](https://github.com/primer/eslint-plugin-primer-react/blob/main/CHANGELOG.md) - [Commits](primer/eslint-plugin-primer-react@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: eslint-plugin-primer-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(eslint): remove unnecessary disable --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * chore(deps-dev): bump babel-plugin-styled-components from 2.0.2 to 2.1.1 (#3139) * chore(deps-dev): bump babel-plugin-styled-components from 2.0.2 to 2.1.1 Bumps [babel-plugin-styled-components](https://github.com/styled-components/babel-plugin-styled-components) from 2.0.2 to 2.1.1. - [Release notes](https://github.com/styled-components/babel-plugin-styled-components/releases) - [Commits](styled-components/babel-plugin-styled-components@v2.0.2...v2.1.1) --- updated-dependencies: - dependency-name: babel-plugin-styled-components dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * test(snapshots): update snapshots --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * chore(project): update project to use Node.js v18 LTS (#3133) * chore(project): update project to use Node.js v18 LTS * chore: add legacy openssl option for docs builds * chore: update devcontainer image --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Use SSR-compatible slot implementation in CheckboxGroup/RadioGroup (#3146) * Update slots for checkbox group and radio group * Update useSlot return type * Update exports test * Create .changeset/young-queens-notice.md * Update comment indentation * Add segments to progressbar (#3114) * Allow ProgressBar to either be given child segments or just a progress value. * Update ProgressBar docs. * Fix progress bar tests. * Create dry-weeks-compete.md * Fix errors from CI. * Rename ProgressBar.Segment to ProgressBar.Item. * Pass backgroundColor instead of bg to get away from system props, simplify children check in ProgressBar. * Updated snapshots. * Updated snapshots using --no-cache flag. * Update generated/components.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(project): move code of conduct under .github (#3145) Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Add npm workspaces structure to primer/react (#3074) * test(axe): default `color-contrast` check to false * chore: update generate script to not conditionally disable contrast checks * Create adr-015-npm-workspaces.md * docs: update adr * Update adr-015-npm-workspaces.md --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Update generated/components.json * change styled_octicon key * Update generated/components.json * Update generated/components.json * Update generated/components.json * Octicon folder * Fix package-lock * Fix imports * update path * Update generated/components.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: jonrohan <jonrohan@users.noreply.github.com> Co-authored-by: Jeremy Neal <radglob@github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josep Martins <josepmartins@github.com> * Allow up to 4 levels of nesting for the NavList (#3343) * allows up to 4 levels of nesting for the NavList * adds changeset * Update src/NavList/NavList.tsx Co-authored-by: Cole Bemis <colebemis@github.com> * updates snapshots --------- Co-authored-by: Cole Bemis <colebemis@github.com> * fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler by @gr2m (#3346) * fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler (#3163) * test: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler Failing test for #3162 * fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`ߴs `onSelect` handler * add storybook example: Delayed Menu Close * update docs * docs: changeset * Update changelog --------- Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> * Update generated/components.json --------- Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com> Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com> * Revert "PageLayout.Content should not use main landmark by default. (#3154)" This reverts commit fed1c57. * Revert "Update `PageLayout` docs around `<main>` usage (#3323)" This reverts commit e1904b2. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes> Co-authored-by: jonrohan <jonrohan@users.noreply.github.com> Co-authored-by: Jeremy Neal <radglob@github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josep Martins <josepmartins@github.com> Co-authored-by: Mike Perrotti <mperrotti@github.com> Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com> Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
broccolinisoup
added a commit
that referenced
this pull request
Jun 20, 2023
…f()` (#3293) * forwardref styl octiocns * remove the comment * add changeset
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
#3389) * Deprecate position prop for PageLayout.Pane, update stories and tests. * Create hungry-spies-remember.md * Fix typo in docs. * Revert PRs that are breaking dotcom to get the current release out (#3408) * Revert "Refactor(ActionList): ActionList.Item should render content as a button if parent is not interactive. (#3284)" This reverts commit 08d7d5d. * Revert "Address ToggleSwitch a11y feedback (#3251)" This reverts commit 580f165. * Revert "Revert "Refactor FilteredActionList to address a11y violations and use new ActionList. (#3247)" (#3349)" This reverts commit a6b4169. * Revert "fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler by @gr2m (#3346)" This reverts commit 6304923. * Revert "Refactor FilteredActionList to address a11y violations and use new ActionList. (#3247)" This reverts commit e865e3e. * Revert "fix(ActionList): update to read from group context if selectionVariant is defined (#3269)" This reverts commit 21ec626. * Revert "Add back check for GroupContext in ActionList.Selection to fix issues introduced to github/github (#3267)" This reverts commit 332a1af. * Revert "Fix create-slots utils path (#3223)" This reverts commit f50997f. * Revert "Allow up to 4 levels of nesting for the NavList (#3343)" This reverts commit 786013e. * Revert "NavList: Fix group dividers (#3328)" This reverts commit 1fd6d32. * Revert "StyledOcticon/Octicon: Update the render func to use `React.forwardRef()` (#3293)" This reverts commit 027d214. * Revert "Rename component StyledOcticon to Octicon (#3148)" This reverts commit ac437bb. * Revert "Update PRC ActionList implementation to have similar semantics to PVC. (#2878)" This reverts commit 87883c3. * Update generated/components.json * Revert "Bump @primer/react-octicons to v19.0.1 (#3266)" This reverts commit 9532977. * Revert "Remove aria-hidden=true from spans with required asterisk (#3320)" This reverts commit 47b7ea0. * Rename component StyledOcticon to Octicon (#3148) * Rename component StyledOcticon to Octicon * Update generated/components.json * Create .changeset/swift-cows-rest.md * Fix snapshot * Add segments to progressbar (#3114) * Allow ProgressBar to either be given child segments or just a progress value. * Update ProgressBar docs. * Fix progress bar tests. * Create dry-weeks-compete.md * Fix errors from CI. * Rename ProgressBar.Segment to ProgressBar.Item. * Pass backgroundColor instead of bg to get away from system props, simplify children check in ProgressBar. * Updated snapshots. * Updated snapshots using --no-cache flag. * refactor(CircleOcticon): Move files to folder, add storybook and e2e tests. (#3119) * Reorganize CircleOcticon files, add story and e2e tests. * Add index file. * Update generated/components.json * refactor(CircleBadge): move files into folder, add e2e tests. (#3118) * Reorganize CircleBadge, add e2e tests. * Update generated/components.json * test(vrt): update snapshots * Update docs reference. --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Refactor(Popover): move files into folder, add storybook and e2e tests. (#3135) * Move files into folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * refactor(ButtonGroup): move files to folder. (#3117) * Reorganize ButtonGroup component and stories. * Update generated/components.json * Add e2e tests. * test(vrt): update snapshots * refactor(CircleBadge): move files into folder, add e2e tests. (#3118) * Reorganize CircleBadge, add e2e tests. * Update generated/components.json * test(vrt): update snapshots * Update docs reference. --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * replace createRef with useRef (#3124) * replace createRef with useRef * changeset * missed null * refactor(FilterList): add files to folder, add storybook and e2e tests. (#3122) * Reorganize FilterList files into folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Refactor(FilteredSearch): move files to folder, add storybook and e2e tests. (#3125) * Move files to folder, add storybook and e2e tests. * Add aria-label to TextInput, fix docs reference. * Update generated/components.json * test(vrt): update snapshots * replace createRef with useRef (#3124) * replace createRef with useRef * changeset * missed null * refactor(FilterList): add files to folder, add storybook and e2e tests. (#3122) * Reorganize FilterList files into folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * Fix generated components. --------- Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> * Refactor(LabelGroup): add files to folder, add storybook and e2e tests. (#3131) * Move files to folder, add storybook and e2e tests. * Update generated/components.json * test(vrt): update snapshots --------- Co-authored-by: radglob <radglob@users.noreply.github.com> * test(e2e): update ActionMenu e2e test to remove custom contrast rules (#3130) * test(e2e): update ActionMenu e2e test to remove custom contrast rules * test(vrt): update snapshots * test: remove multiple sections test * test(e2e): restore rule exception for ActionMenu --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * NavList SSR: use useIsomorphicLayoutEffect instead of useLayoutEffect (#3127) * use useIsomorphicLayoutEffect * Create .changeset/fast-panthers-refuse.md --------- Co-authored-by: Josh Black <joshblack@github.com> * Bump @primer/primitives to `7.11.5` (#3120) * npm install @primer/primitives@7.11.5 * Updating`theme-preval` snapshots * Re-run ``` npm run build npm run test -- -u ``` So that /themePreval.test.ts.snap also gets the new timestamp * Update `theme-preval` snapshots docs * Create .changeset/old-falcons-learn.md * test(vrt): update snapshots --------- Co-authored-by: simurai <simurai@users.noreply.github.com> * Update RelativeTime stories (#3136) * Update RelativeTime stories * Update generated/components.json --------- Co-authored-by: colebemis <colebemis@users.noreply.github.com> * chore(deps-dev): bump @types/jest-axe from 3.5.3 to 3.5.5 (#3141) Bumps [@types/jest-axe](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest-axe) from 3.5.3 to 3.5.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest-axe) --- updated-dependencies: - dependency-name: "@types/jest-axe" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @rollup/plugin-typescript from 11.0.0 to 11.1.0 (#3138) Bumps [@rollup/plugin-typescript](https://github.com/rollup/plugins/tree/HEAD/packages/typescript) from 11.0.0 to 11.1.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/typescript/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v11.1.0/packages/typescript) --- updated-dependencies: - dependency-name: "@rollup/plugin-typescript" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump eslint-plugin-primer-react from 2.0.2 to 2.0.3 (#3140) * chore(deps-dev): bump eslint-plugin-primer-react from 2.0.2 to 2.0.3 Bumps [eslint-plugin-primer-react](https://github.com/primer/eslint-plugin-primer-react) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/primer/eslint-plugin-primer-react/releases) - [Changelog](https://github.com/primer/eslint-plugin-primer-react/blob/main/CHANGELOG.md) - [Commits](primer/eslint-plugin-primer-react@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: eslint-plugin-primer-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(eslint): remove unnecessary disable --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * chore(deps-dev): bump babel-plugin-styled-components from 2.0.2 to 2.1.1 (#3139) * chore(deps-dev): bump babel-plugin-styled-components from 2.0.2 to 2.1.1 Bumps [babel-plugin-styled-components](https://github.com/styled-components/babel-plugin-styled-components) from 2.0.2 to 2.1.1. - [Release notes](https://github.com/styled-components/babel-plugin-styled-components/releases) - [Commits](styled-components/babel-plugin-styled-components@v2.0.2...v2.1.1) --- updated-dependencies: - dependency-name: babel-plugin-styled-components dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * test(snapshots): update snapshots --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * chore(project): update project to use Node.js v18 LTS (#3133) * chore(project): update project to use Node.js v18 LTS * chore: add legacy openssl option for docs builds * chore: update devcontainer image --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Use SSR-compatible slot implementation in CheckboxGroup/RadioGroup (#3146) * Update slots for checkbox group and radio group * Update useSlot return type * Update exports test * Create .changeset/young-queens-notice.md * Update comment indentation * Add segments to progressbar (#3114) * Allow ProgressBar to either be given child segments or just a progress value. * Update ProgressBar docs. * Fix progress bar tests. * Create dry-weeks-compete.md * Fix errors from CI. * Rename ProgressBar.Segment to ProgressBar.Item. * Pass backgroundColor instead of bg to get away from system props, simplify children check in ProgressBar. * Updated snapshots. * Updated snapshots using --no-cache flag. * Update generated/components.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(project): move code of conduct under .github (#3145) Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Add npm workspaces structure to primer/react (#3074) * test(axe): default `color-contrast` check to false * chore: update generate script to not conditionally disable contrast checks * Create adr-015-npm-workspaces.md * docs: update adr * Update adr-015-npm-workspaces.md --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Update generated/components.json * change styled_octicon key * Update generated/components.json * Update generated/components.json * Update generated/components.json * Octicon folder * Fix package-lock * Fix imports * update path * Update generated/components.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: jonrohan <jonrohan@users.noreply.github.com> Co-authored-by: Jeremy Neal <radglob@github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josep Martins <josepmartins@github.com> * Allow up to 4 levels of nesting for the NavList (#3343) * allows up to 4 levels of nesting for the NavList * adds changeset * Update src/NavList/NavList.tsx Co-authored-by: Cole Bemis <colebemis@github.com> * updates snapshots --------- Co-authored-by: Cole Bemis <colebemis@github.com> * fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler by @gr2m (#3346) * fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler (#3163) * test: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler Failing test for #3162 * fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`ߴs `onSelect` handler * add storybook example: Delayed Menu Close * update docs * docs: changeset * Update changelog --------- Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> * Update generated/components.json --------- Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com> Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com> * Revert "PageLayout.Content should not use main landmark by default. (#3154)" This reverts commit fed1c57. * Revert "Update `PageLayout` docs around `<main>` usage (#3323)" This reverts commit e1904b2. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes> Co-authored-by: jonrohan <jonrohan@users.noreply.github.com> Co-authored-by: Jeremy Neal <radglob@github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josep Martins <josepmartins@github.com> Co-authored-by: Mike Perrotti <mperrotti@github.com> Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com> Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com> * Version Packages (#3218) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update changeset to mention changed component. * Put changed components comment after changeset write up. * Fix some spacing issues, docs and story changes. * Update snapshots, formatting and linting. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Armağan <broccolinisoup@github.com> Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes> Co-authored-by: jonrohan <jonrohan@users.noreply.github.com> Co-authored-by: radglob <radglob@users.noreply.github.com> Co-authored-by: Matthew Costabile <mattcosta7@github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> Co-authored-by: simurai <simurai@github.com> Co-authored-by: simurai <simurai@users.noreply.github.com> Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: colebemis <colebemis@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josep Martins <josepmartins@github.com> Co-authored-by: Mike Perrotti <mperrotti@github.com> Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com> Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com> Co-authored-by: GitHub Design Systems Bot <30705008+primer-css@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated our icons to use
React.forwardRef()from being a normal function components. primer/octicons#943This was required for the
Tooltipa11y remediation work and we also need to update theOcticons(akaStyledOcticon) render function so that we can access their refs to do our accessibility checks. I tested the changes at dotcom and seems to be good.Screenshots
No visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.