Skip to content

Refactor(Portal): move stories into Portal directory. #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion generated/components.json
Original file line number Diff line number Diff line change
Expand Up @@ -3120,7 +3120,12 @@
"name": "Portal",
"status": "alpha",
"a11yReviewed": false,
"stories": [],
"stories": [
{
"id": "components-portal--default",
"code": "() => (\n <>\n Root position\n <Box bg=\"red.2\" p={3}>\n Outer container\n <Box bg=\"green.2\" p={3}>\n Inner container\n <Portal>\n Portaled content rendered at <code>&lt;BaseStyles&gt;</code> root.\n </Portal>\n </Box>\n </Box>\n </>\n)"
}
],
"props": [
{
"name": "onMount",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,39 +1,12 @@
import React from 'react'
import {Meta} from '@storybook/react'

import {BaseStyles, Box, ThemeProvider} from '..'
import Portal, {registerPortalRoot} from '../Portal'
import {ComponentMeta} from '@storybook/react'
import Box from '../Box'
import {Portal, registerPortalRoot} from './Portal'

export default {
title: 'Behaviors/Portal',
title: 'Behaviors/Portal/Features',
component: Portal,
decorators: [
Story => {
return (
<ThemeProvider>
<BaseStyles>
<Story />
</BaseStyles>
</ThemeProvider>
)
},
],
} as Meta

export const DefaultPortal = () => (
<>
Root position
<Box bg="red.2" p={3}>
Outer container
<Box bg="green.2" p={3}>
Inner container
<Portal>
Portaled content rendered at <code>&lt;BaseStyles&gt;</code> root.
</Portal>
</Box>
</Box>
</>
)
} as ComponentMeta<typeof Portal>

export const CustomPortalRootById = () => (
<>
Expand Down
25 changes: 25 additions & 0 deletions src/Portal/Portal.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import React from 'react'
import {ComponentMeta} from '@storybook/react'

import {Box} from '..'
import {Portal} from './Portal'

export default {
title: 'Behaviors/Portal',
component: Portal,
} as ComponentMeta<typeof Portal>

export const Default = () => (
<>
Root position
<Box bg="red.2" p={3}>
Outer container
<Box bg="green.2" p={3}>
Inner container
<Portal>
Portaled content rendered at <code>&lt;BaseStyles&gt;</code> root.
</Portal>
</Box>
</Box>
</>
)