Skip to content

Configure ssr-friendly eslint plugin - #3164

Merged
colebemis merged 2 commits into
mainfrom
ssr-lint
Apr 13, 2023
Merged

colebemis merged 2 commits into
mainfrom
ssr-lint

Conversation

@colebemis

@colebemis colebemis commented Apr 12, 2023 •

Copy link
Copy Markdown
Contributor

To ensure that Primer React components are SSR-compatible, we must verify that they don't misuse DOM globals. This PR configures an ESLint plugin called ssr-friendly to catch incorrect use of DOM globals in React components.

Part of https://github.com/github/primer/issues/1975

@changeset-bot

changeset-bot Bot commented Apr 12, 2023 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e5723df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Apr 12, 2023 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 95.77 KB (0%)
dist/browser.umd.js 96.38 KB (0%)

@colebemis
colebemis temporarily deployed to github-pages April 12, 2023 21:33 — with GitHub Actions Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview-3164 April 12, 2023 21:33 Inactive
@colebemis colebemis added the skip changeset This change does not need a changelog label Apr 12, 2023
@colebemis
colebemis marked this pull request as ready for review April 12, 2023 21:53
@colebemis
colebemis requested review from a team and joshblack April 12, 2023 21:53
@github-actions
github-actions Bot temporarily deployed to storybook-preview-3164 April 12, 2023 21:53 Inactive
@colebemis
colebemis added this pull request to the merge queue Apr 13, 2023
Merged via the queue into main with commit 7272924 Apr 13, 2023
@colebemis
colebemis deleted the ssr-lint branch April 13, 2023 16:33

This branch was successfully deployed

1 active and 1 inactive deployments
storybook-preview-3164 — e5723df8 Deployed Apr 12, 2023 by github-actions[bot]
github-pages — e5723df8 Deployed Apr 12, 2023 by colebemis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants