Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames 'shrink' column width to 'growCollapse' #3085

Merged
merged 5 commits into from
Mar 29, 2023

Conversation

mperrotti
Copy link
Contributor

I think "shrink" could be confused for a width that makes the column narrower. "growCollapse" is a more accurate name for the actual behavior:

'growCollapse': Stretch to fill available space or shrink to fit in the available space. Allows the column to shrink smaller than the cell content's width.

Screenshots

No visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and broccolinisoup March 28, 2023 17:22
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

🦋 Changeset detected

Latest commit: 44b72cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95 KB (0%)
dist/browser.umd.js 95.55 KB (0%)

@mperrotti mperrotti temporarily deployed to github-pages March 28, 2023 17:32 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3085 March 28, 2023 17:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants