Add horizontal alignment to column configuration #3068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb61132 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Looks great! Just left a comment for the CSS Selector.
Also wanted to ask if we wanted a shared Alignment or BlockAlignment type after seeing the ToggleSwitch update. I think seeing CellAlignment there was unexpected since I didn't think of it as a cell but totally get wanting alignment values to be consistent across the library/design system 👍
src/DataTable/Table.tsx
Outdated
| justify-content: flex-end; | ||
| } | ||
|
|
||
| .TableHeader[data-cell-align='end'] > button { |
There was a problem hiding this comment.
Could we add a class to the table sort button instead of using an element selector?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/1959
Screenshots
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.