Skip to content

refactor(AvatarPair): move files to folder, add e2e tests and stories #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 17, 2023
Merged

refactor(AvatarPair): move files to folder, add e2e tests and stories #2906

merged 6 commits into from
Feb 17, 2023

Conversation

josepmartins
Copy link
Contributor

Tracking issue: https://github.com/github/primer/issues/1488

Add storybook stories for AvatarPair

Checklist

  • Ensure your chosen component has a component directory in the src directory
  • Ensure the component has a root story file in the component directory
  • Ensure that the root story file exports a Default story
  • (Optional) Create a Playground story
  • Move all other stories for the component into a .features.stories.tsx file
  • Opt the component into storybook tests
  • (Optional) Create visual regression tests for the component

@josepmartins josepmartins requested review from a team and siddharthkp February 17, 2023 09:46
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 707c138

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@josepmartins josepmartins added skip changeset This change does not need a changelog update snapshots labels Feb 17, 2023
@josepmartins josepmartins changed the title refactor(Avatar): move files to folder, add e2e tests and stories refactor(AvatarPair): move files to folder, add e2e tests and stories Feb 17, 2023
@josepmartins josepmartins temporarily deployed to github-pages February 17, 2023 09:55 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2906 February 17, 2023 09:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2906 February 17, 2023 10:06 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 94.5 KB (+0.01% 🔺)
dist/browser.umd.js 95.08 KB (+0.01% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-2906 February 17, 2023 10:13 Inactive
@josepmartins josepmartins temporarily deployed to github-pages February 17, 2023 10:13 — with GitHub Actions Inactive
@josepmartins josepmartins mentioned this pull request Feb 17, 2023
Closed
72 tasks
@colebemis colebemis added this pull request to the merge queue Feb 17, 2023
Merged via the queue into main with commit a4a12bd Feb 17, 2023
@colebemis colebemis deleted the docs/add-avatar-pair-stories branch February 17, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josepmartins @colebemis