Skip to content

TreeView: Set aria-selected=true on focused item #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 8, 2023

Conversation

colebemis
Copy link
Contributor

Sets aria-selected=true on the focused treeitem, as described by the TreeView API spec

Closes #2840

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2023

🦋 Changeset detected

Latest commit: a125413

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis marked this pull request as ready for review February 7, 2023 23:43
@colebemis colebemis requested review from a team, JoshBowdenConcepts and joshblack and removed request for JoshBowdenConcepts February 7, 2023 23:43
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 89.69 KB (0%)
dist/browser.umd.js 89.76 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-2875 February 7, 2023 23:48 Inactive
@colebemis colebemis temporarily deployed to github-pages February 7, 2023 23:49 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2875 February 7, 2023 23:49 Inactive
@colebemis colebemis temporarily deployed to github-pages February 8, 2023 03:15 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2875 February 8, 2023 03:16 Inactive
@colebemis colebemis temporarily deployed to github-pages February 8, 2023 06:39 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2875 February 8, 2023 06:40 Inactive
@colebemis colebemis temporarily deployed to github-pages February 8, 2023 06:49 — with GitHub Actions Inactive
@colebemis colebemis merged commit 2a00aab into main Feb 8, 2023
@colebemis colebemis deleted the treeview-aria-selected branch February 8, 2023 06:58
@primer-css primer-css mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TreeView.Item to specify aria-selected on element with role="treeitem"
2 participants