Skip to content

feat(DataTable): add support for title and subtitle #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jan 30, 2023

Add support for title and subtitle for DataTable based on: https://github.com/github/primer/pull/1712

This PR adds in TableContainer, TableTitle, and TableSubtitle along with documentation to link the title and subtitle to a table. This work does not include support for table actions.

This work differs from the API doc in that TableContainer is being used for the overall container where-as I believe DataTable was the containing element in the proposal. Currently, DataTable is used to represent the table itself. Naming seems to be something we can address outside of this PR, instead this is meant to:

  • Check that the styles are correct for titles, subtitles
  • Check that the markup is correct for titles, subtitles

Changelog

New

  • Add TableContainer component for laying out the table
  • Add TableTitle component for providing a table title
  • Add TableSubtitle component for providing a table description
  • Add feature stories for DataTable

Changed

  • Update label and description tests to include support for TableTitle and TableSubtitle for labeling and describing a Table
  • Update docs.json for DataTable to include TableContainer, TableTitle, and TableSubtitle
  • Update storybook config to no longer warn on controls in feature stories

Removed

@joshblack joshblack requested review from a team and siddharthkp January 30, 2023 20:15
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023

⚠️ No Changeset found

Latest commit: c921bd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 89.59 KB (0%)
dist/browser.umd.js 90.22 KB (0%)

Copy link
Contributor

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a TypeScript expert, but this looks good from my perspective.

@github-actions github-actions bot temporarily deployed to storybook-preview-2839 January 30, 2023 20:23 Inactive
@primer primer bot temporarily deployed to github-pages January 30, 2023 20:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2839 January 30, 2023 20:24 Inactive
@joshblack joshblack requested review from colebemis and removed request for siddharthkp January 31, 2023 17:05
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a couple comments about using design tokens

@joshblack joshblack temporarily deployed to github-pages February 6, 2023 19:03 — with GitHub Actions Inactive
Base automatically changed from feat/add-basic-table to main February 6, 2023 20:04
@joshblack joshblack force-pushed the feat/add-table-container branch from 4130994 to c921bd8 Compare February 6, 2023 20:07
@joshblack joshblack closed this Feb 6, 2023
@jonrohan jonrohan deleted the feat/add-table-container branch May 9, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants