-
Notifications
You must be signed in to change notification settings - Fork 616
feat(DataTable): add support for title and subtitle #2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a TypeScript expert, but this looks good from my perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a couple comments about using design tokens
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
4130994
to
c921bd8
Compare
Add support for title and subtitle for
DataTable
based on: https://github.com/github/primer/pull/1712This PR adds in
TableContainer
,TableTitle
, andTableSubtitle
along with documentation to link the title and subtitle to a table. This work does not include support for table actions.This work differs from the API doc in that
TableContainer
is being used for the overall container where-as I believeDataTable
was the containing element in the proposal. Currently,DataTable
is used to represent the table itself. Naming seems to be something we can address outside of this PR, instead this is meant to:Changelog
New
TableContainer
component for laying out the tableTableTitle
component for providing a table titleTableSubtitle
component for providing a table descriptionDataTable
Changed
TableTitle
andTableSubtitle
for labeling and describing aTable
DataTable
to includeTableContainer
,TableTitle
, andTableSubtitle
Removed