Skip to content

Issue @deprecated notice for the UnderlineNav v1 #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 7, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Jan 30, 2023

Describe your changes here.

Issuing a @deprecate notice for the UnderlineNav v1 as we are planning to deprecate the component in the next major release v36.

Please see the references. (comment, documentation)

Screenshots

No visual changes.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023

🦋 Changeset detected

Latest commit: de5396a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 89.69 KB (0%)
dist/browser.umd.js 89.76 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-2834 January 30, 2023 04:32 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages January 30, 2023 04:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2834 January 30, 2023 04:37 Inactive
@broccolinisoup broccolinisoup marked this pull request as ready for review January 30, 2023 05:32
@broccolinisoup broccolinisoup requested review from a team and siddharthkp January 30, 2023 05:32
@broccolinisoup broccolinisoup changed the title Issue @deprecate notice for the UnderlineNav v1 Issue @deprecated notice for the UnderlineNav v1 Jan 31, 2023
Co-authored-by: Josh Black <joshblack@github.com>
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 6, 2023 01:11 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2834 February 6, 2023 01:11 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 6, 2023 01:24 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2834 February 6, 2023 01:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2834 February 6, 2023 01:25 Inactive
@broccolinisoup broccolinisoup enabled auto-merge (squash) February 7, 2023 21:34
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 7, 2023 21:38 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2834 February 7, 2023 21:39 Inactive
@broccolinisoup broccolinisoup deleted the bs/deprecation-notice branch February 7, 2023 22:09
@primer-css primer-css mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants