Prevent default clicking on markdown preview links when using openLinksInNewTab
#2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 43ef170 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marywhite
commented
Dec 20, 2022
| // error when clicking the link above. The spy here captures this error | ||
| // and will assert that it is called only once, otherwise another error | ||
| // in this test has occurred | ||
| expect(spy).toHaveBeenCalledTimes(1) |
There was a problem hiding this comment.
This test was previously asserting the buggy behavior - now that we're not navigating the page (the call to window.open is mocked), we don't see any error.
dusave
approved these changes
Jan 6, 2023
mattcosta7
approved these changes
Jan 6, 2023
auto-merge was automatically disabled
January 9, 2023 17:08
Head branch was pushed to by a user without write access
|
@joshblack are you able to reenable auto-merge? pushed out a linting fix and I don't have access to merge 🙏 |
|
@marywhite on it! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
Closes #2717
MarkdownVieweraccepts anopenLinksInNewTabprop to ensure link previews open in a new tab. Because default is not prevented, navigation is also happening in the working tab.I've also added gone ahead and added
noopener noreferrerto the call towindow.opens/o @mattcosta7Screenshots
Before:
link-navigation-before.mov
After:
link-navigation-after.mov
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.