Skip to content

Conversation

@colebemis
Copy link
Contributor

Before

Focusing/clicking a child item would unexpectedly scroll the parent item into view:

CleanShot.2022-11-02.at.12.02.59.mp4

After

The TreeView doesn't scroll unexpectedly when focusing/clicking child items:

CleanShot.2022-11-02.at.12.03.45.mp4

Closes #2505

Merge checklist

  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@colebemis colebemis requested review from a team and josepmartins November 2, 2022 19:06
@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022

🦋 Changeset detected

Latest commit: d267897

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis added the component: TreeView Issues related to the TreeView component label Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 78.87 KB (0%)
dist/browser.umd.js 79.51 KB (0%)

@colebemis colebemis temporarily deployed to github-pages November 2, 2022 19:14 Inactive
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@colebemis colebemis temporarily deployed to github-pages November 2, 2022 19:32 Inactive
@colebemis colebemis merged commit 862f93c into main Nov 2, 2022
@colebemis colebemis deleted the treeview-scroll-fix branch November 2, 2022 21:19
@primer-css primer-css mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: TreeView Issues related to the TreeView component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TreeView scrolling instead of selecting

4 participants