-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix label colors for border and text #2487
Conversation
Fix label colors for border and text were mixed up.
🦋 Changeset detectedLatest commit: be6692a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just left a non blocking comment/question
Gotcha, thank you! 👍 |
@colebemis or @rezrah can you help me with the failing changeset? What do I need to do? |
Hi @lukasoppermann 👋🏼 It is complaining because there is no changeset file for this change. You can read about changesets here but for a brief intro, we use them for release tracking purposes. Changeset files include info about what we need to release and what level of versioning i.e. patch/minor/major (ref: semver )) I believe this PR is a patch. And you can run |
Label colors for border and text were mixed up for variants
done
andsponsors
.This leads to an a11y issue were text colors don't pass.