Resizable pane refactor #2481
Merged
Resizable pane refactor #2481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
colebemis
added a commit
that referenced
this pull request
Oct 31, 2022
* add resizable support to the PageLayout component * Add changeset file * update snapshot * take client left position into account when pane is not left aligned * fix resize behavior when pane is not at start position * fix resize when there are column gaps * use story debug values * decouple the resize handle from the vertical divider * update snap file * update snap file * rename canResizePane to resizable * update snap files * update resizable PageLayout story * rename paneWidthStorageKey to widthStorageKey * refactor(PageLayout): set pane with in CSS Custom Property * docs: add documentation for resizable nad widthStorageKey * Resizable pane refactor (#2481) * Update stories * Refactor resizable pane implementation * Clamp pane width resizing * Delay drag hover effect * Reset pane width on double click * Handle styles while dragging * Add resizable example to SplitPageLayout docs * Remove comment * Add comment about touch events * Update docs * Update resizable pane story * Update snapshots * Wrap localStorage in try/catch * Store pane width in px * Update snapshot * Update pagelayout snapshots Co-authored-by: Josh Black <josh@josh.black> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Cole Bemis <colebemis@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CleanShot.2022-10-25.at.16.18.32.mp4
TODO
Support touch events(out of scope)