fix(TabNav): update focus strategy after initial focus #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 25b78c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
… into 2340-add-tmp-fix-for-tabnav
mperrotti
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
I tested the fix using the example from this CodeSandbox.
It works and I understand why 👍
I just want to confirm that users should not expect to have focus moved to the tabs when focused on the previous element and press the right arrow, or when focused on the next element and press the left arrow.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2340
This PR introduces a temporary fix for
TabNavto allow its participation in parent focus zones (like when used inActionMenu). It tracks when initial focus was set in order to supportaria-selectedand then uses thepreviousstrategy inuseFocusZoneafterwards to mirror a typical roving index setup.This allows its participation in parent focus zones that are expecting a different item to be focused than the current focus strategy present in
TabNav(which defaults to thearia-selectedtab)Testing
I re-created the codesandbox from: #2340 inside of a story in
ActionMenu/examples.stories.tsxas a test for this scenario. I don't believe this should be an official story since this scenario is not supported but wanted to share to help out reviewers to re-create the original issue and verify the fix.