Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align status component table to primer.style/status table #2467

Merged
merged 7 commits into from
Oct 26, 2022

Conversation

josepmartins
Copy link
Contributor

Describe your changes here.

Align the accessbile column with the https://primer.style/status/ table

  • Use Label for empty accessible rows
  • Adjust label copies to 'Not reviewedandReviewed`
  • Add done functional colors

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@josepmartins josepmartins requested review from a team and rezrah October 21, 2022 10:26
@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2022

🦋 Changeset detected

Latest commit: 3825958

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@josepmartins josepmartins changed the title Josepmartins/status label upates Align status component table to primer.style/status table Oct 21, 2022
@josepmartins josepmartins marked this pull request as draft October 21, 2022 10:28
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 78.14 KB (0%)
dist/browser.umd.js 78.79 KB (0%)

@josepmartins josepmartins force-pushed the josepmartins/status-label-upates branch from d2abec9 to d76e26d Compare October 21, 2022 10:33
@josepmartins josepmartins marked this pull request as ready for review October 21, 2022 10:34
@josepmartins josepmartins added the docs Documentation label Oct 21, 2022
@josepmartins josepmartins temporarily deployed to github-pages October 21, 2022 10:42 Inactive
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@josepmartins josepmartins temporarily deployed to github-pages October 23, 2022 16:04 Inactive
@josepmartins josepmartins temporarily deployed to github-pages October 25, 2022 08:20 Inactive
@josepmartins josepmartins self-assigned this Oct 25, 2022
@josepmartins josepmartins temporarily deployed to github-pages October 25, 2022 15:28 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josepmartins josepmartins temporarily deployed to github-pages October 26, 2022 07:25 Inactive
@josepmartins josepmartins merged commit d396c89 into main Oct 26, 2022
@josepmartins josepmartins deleted the josepmartins/status-label-upates branch October 26, 2022 08:35
@primer-css primer-css mentioned this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants