Skip to content

TreeView: Add aria-atomic attribute to live region #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

colebemis
Copy link
Contributor

Adds aria-atomic="true" to TreeView live region based on accessibility feedback.

@colebemis colebemis requested review from a team and siddharthkp October 20, 2022 23:34
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2022

🦋 Changeset detected

Latest commit: ff0caa6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis requested a review from ericwbailey October 20, 2022 23:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 77.99 KB (0%)
dist/browser.umd.js 78.64 KB (0%)

@colebemis colebemis temporarily deployed to github-pages October 20, 2022 23:41 Inactive
Copy link
Contributor

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short, and to the point!

@colebemis colebemis merged commit 2cd11b7 into main Oct 21, 2022
@colebemis colebemis deleted the treeview-aria-atomic branch October 21, 2022 17:45
@primer-css primer-css mentioned this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants