Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: Remove landmark elements #2444

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Dialog: Remove landmark elements #2444

merged 2 commits into from
Oct 17, 2022

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Oct 17, 2022

Remove landmark elements from Dialog based on accessibility feedback from @kendallgassner: #2352 (comment)

Will you remove the banner and footer landmark semantics on the dialog component. These landmarks should not be in a dialog since they are not a standalone page.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

🦋 Changeset detected

Latest commit: 58c5884

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis marked this pull request as ready for review October 17, 2022 21:25
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 77.91 KB (-0.02% 🔽)
dist/browser.umd.js 78.55 KB (-0.03% 🔽)

Copy link
Contributor

@kendallgassner kendallgassner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thank you!

@colebemis colebemis temporarily deployed to github-pages October 17, 2022 21:33 Inactive
@colebemis colebemis merged commit 2b6323c into main Oct 17, 2022
@colebemis colebemis deleted the dialog-remove-landmarks branch October 17, 2022 21:38
@primer-css primer-css mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants