fix(TreeView): add outline transparent for visible focus indicators #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b4fcd93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
Is it possible to add before/after screenshots to the PR description? |
|
@colebemis of course! Updated the description with a loom and some screenshots. |
colebemis
approved these changes
Oct 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates TreeView based on feedback received for WHCM (Windows High Contrast Mode), specifically around focus and hover styles.
https://github.com/github/primer/issues/815#issuecomment-1273922579
By default, it uses a transparent outline in forced-colors: 'active' mode which will be visible in WHCM. For focus, it uses the
SelectedItemkeyword using the same technique.Preview of changes: https://www.loom.com/share/3c518ae9c39f4ed7b015010dd03e37c2
Before
Hover
Focus
After
Hover
Focus