Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TreeView based on a11y feedback #2428

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Update TreeView based on a11y feedback #2428

merged 4 commits into from
Oct 12, 2022

Conversation

joshblack
Copy link
Member

This PR addresses the following items from: https://github.com/github/primer/issues/815#issuecomment-1273922579

  • Call event.preventDefault() on arrow key events
  • Fix overlapping hover background and focus ring

Note: let me know if the refactor for the arrow key behavior isn't as clear as the original, happy to revert back!

@joshblack joshblack requested review from colebemis and a team October 12, 2022 20:44
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

🦋 Changeset detected

Latest commit: 2ada3e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 77.66 KB (0%)
dist/browser.umd.js 78.34 KB (0%)

@joshblack joshblack temporarily deployed to github-pages October 12, 2022 20:54 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshblack joshblack temporarily deployed to github-pages October 12, 2022 21:29 Inactive
@joshblack joshblack merged commit 7ad9e77 into main Oct 12, 2022
@joshblack joshblack deleted the fix/update-tree-view branch October 12, 2022 21:47
@primer-css primer-css mentioned this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants