Skip to content

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Sep 7, 2018

Fixes #241. This does a couple of things:

  1. Removes .npmignore
  2. Adds a files field to package.json that whitelists the dist and src directories and then blacklists src/__tests__ and src/utils, since these are only used by tests
  3. Removes a couple of files from now.json so that they're not deployed
  4. Moves our jest configuration out of package.json and into jest.config.js, reducing the size of the file that gets published.
  5. Adds a shell script script/npm-pack-check, which checks that the certain files are and are not included in the tarball that gets published to npm. (There's probably an npm module for this, but I couldn't find one after a cursory search, and would be happy to extract this later for use in other Primer repos.)

TODO

@vercel
Copy link

vercel bot commented Sep 7, 2018

This pull request is automatically deployed with Now.

To access deployments, click Details below or on the icon next to each push.

@shawnbot shawnbot requested a review from emplums September 10, 2018 19:23
@shawnbot
Copy link
Contributor Author

@emplums this was intended to merge into #238, but because it touches npm publish logic it might be better to merge into our next release branch.

Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@shawnbot shawnbot changed the base branch from path-alias to master September 11, 2018 18:13
@shawnbot shawnbot changed the base branch from master to path-alias September 11, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants