-
Notifications
You must be signed in to change notification settings - Fork 639
Streamline npm publish and Now deploy files #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
emplums
approved these changes
Sep 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This was referenced Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241. This does a couple of things:
.npmignore
files
field topackage.json
that whitelists thedist
andsrc
directories and then blacklistssrc/__tests__
andsrc/utils
, since these are only used by testsnow.json
so that they're not deployedpackage.json
and intojest.config.js
, reducing the size of the file that gets published.script/npm-pack-check
, which checks that the certain files are and are not included in the tarball that gets published to npm. (There's probably an npm module for this, but I couldn't find one after a cursory search, and would be happy to extract this later for use in other Primer repos.)TODO
Update base branch torelease-2.0.2-beta