Fix merge button #229
Merged
Fix merge button #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emplums
approved these changes
Aug 24, 2018
|
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
|
FYI, this is what the MergeButton looks like now:
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression with the MergeButton demo reported on Spectrum. The problem appears to be that we forgot to replace the
<Box position="absolute">with<Absolute>.While I was in the inspector I noticed that some styles were being applied via the
styleprop, which Emotion ignores. I switched these to use thecssprop (from system-components) so that the styles are handled by Emotion, and upgraded the down arrow in our MergeButton component with astyled('span')that gets the same CSS.I've also eliminated all of the utility classes from that demo! 🎉