Small improvements to MarkdownEditor component#2236
Merged
iansan5653 merged 8 commits intomainfrom Aug 23, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: d62f317 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iansan5653
force-pushed
the
improve-markdown-editor
branch
from
d8bbb7b to
28e61fb
Compare
Contributor
size-limit report 📦
|
siddharthkp
approved these changes
Aug 22, 2022
iansan5653
commented
Aug 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has some minor followup changes to #2182:
Refpassed toMarkdownEditorso that consumers cannot accidentally create the ref usinguseRef<HTMLTextAreaElement>. This was possible before becauseHTMLElementwas assignable toMarkdownEditorHandle, so I added a fake symbol 'brand' key to disallow this. It's somewhat hacky but worth it to prevent a very common mistake.MarkdownViewerdocs so the examples will render (they are erroring withTypeError: Cannot read properties of undefined (reading '__html')).This fixes #2231, except for erroring when there is no
Labelpresent - I tried to fix this but it's very hard to do with the current implementation of slots. I think it's not worth the extra lift right now.Merge checklist