Skip to content

(test) revert #2204 #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

(test) revert #2204 #2235

wants to merge 2 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Aug 16, 2022

1 single test is failing when I tried to upgrade primer/react to 35.6.0 in the monolith: https://github.com/github/github/pull/232173

The test: https://github.com/github/github/blob/master/app/assets/modules/react-shared/RefSelector/__tests__/RefSelector.test.tsx

I've narrowed it down to #2204.

Confirmed by this PR, reverting #2204 passes the test (canary release: 0.0.0-2022716161117)

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022

⚠️ No Changeset found

Latest commit: 7b791d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp changed the title revert #2204 (ignore) revert #2204 Aug 16, 2022
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 73.24 KB (-1.3% 🔽)
dist/browser.umd.js 73.83 KB (-1.23% 🔽)

@siddharthkp siddharthkp temporarily deployed to github-pages August 16, 2022 16:14 Inactive
@siddharthkp siddharthkp changed the title (ignore) revert #2204 (test) revert #2204 Aug 16, 2022
@siddharthkp siddharthkp closed this Sep 1, 2022
@joshblack joshblack deleted the tmp-test branch January 19, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant