-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtle border to the avatar to match the CSS implementation #2206
Conversation
🦋 Changeset detectedLatest commit: bc7b85a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Hi! Do you have access to the chromatic build to make sure all the visual changes are intentional: https://www.chromatic.com/build?appId=61a90feace7802003a4d9c45&number=1009 Side note: In case you want, you can review all the different themes at once now: https://primer-6e414db3be-13348165.drafts.github.io/storybook/?path=/story/tokens-avatartoken--default-token&globals=colorScheme:all Side note 2: You might need to update jest snapshots by running |
Hey @siddharthkp I forgot about Chromatic, it's so good! 🥹 The visual changes look good. I've tried to update the snapshots but I got into an error: |
I'm not 100% sure, but I think running |
The avatar was missing a border compared to the css implementation.
The change is best visible in dark modes with @colebemis's avatar.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.