Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #2040

Merged
merged 82 commits into from
Aug 3, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
b4d325d
Fix typos
PrinceSumberia Apr 21, 2022
21a0b6e
Merge branch 'main' into fix-typos
mperrotti Apr 28, 2022
ea5858d
Namespace UnderlineNav (#2053)
langermank May 3, 2022
a0b5f4e
Version Packages (#2034)
primer-css May 3, 2022
68a8630
Select component a11y fixes (#2038)
mperrotti May 4, 2022
000fa72
Finish updating global focus styles (#2050)
mperrotti May 5, 2022
b2bc8a0
Tooltip: anchoredPosition + IconButton (#2006)
siddharthkp May 10, 2022
efbf0cf
Implement NavList component (part 1) (#2058)
colebemis May 10, 2022
bb1681b
ThemeProvider: Fix theme sync with system settings (#2048)
siddharthkp May 11, 2022
fe3c0a8
Move theme decorator into helper util (#2044)
siddharthkp May 11, 2022
262d1ad
Add missing changelog for #2006! (#2069)
siddharthkp May 12, 2022
9bdfdb3
Implement NavList.SubNav (#2064)
colebemis May 16, 2022
1611055
Update issue templates for this repo to include redirects to pattern …
lesliecdubs May 16, 2022
e46a318
Fix ButtonGroup component and add docs (#2054)
colebemis May 16, 2022
69d12e0
ActionMenu: adjust width based on padding (#2080)
siddharthkp May 18, 2022
f6b91d1
Form component design tweaks (#2057)
mperrotti May 18, 2022
50488e8
NavList: Add `sx` prop (#2077)
colebemis May 18, 2022
06077e1
Fix broken inline component links (#2082)
mperrotti May 19, 2022
9c92d10
Fix ActionMenu with IconButton (#2084)
siddharthkp May 19, 2022
46d75c7
NavList.Item: Add `as` prop (#2076)
colebemis May 19, 2022
51f0b4a
Fixes `onRemove` console error coming from token components (#2087)
mperrotti May 20, 2022
bab2bdb
Fix overflow issues in PageLayout.Content (#2075)
colebemis May 23, 2022
9ba988a
Uncomment guard (#2091)
siddharthkp May 23, 2022
36afe56
Revert accessible Tooltip + IconButton (#2092)
siddharthkp May 24, 2022
82ed815
Version Packages (#2056)
primer-css May 24, 2022
47d9a25
Bump doctocat version (#2096)
colebemis May 24, 2022
5bc624b
Fix Dialog example (#2083)
ty-v1 May 24, 2022
454d1d5
Set aria-multiselectable in SelectPanel (#2095)
hectahertz May 25, 2022
e925621
Reduce storybook build time in CI to < 2 mins (#2093)
siddharthkp May 25, 2022
5841622
Adds draft SegmentedControl docs (#2081)
mperrotti May 26, 2022
05acb26
Tests: Add tests for lockfile version (#2106)
siddharthkp Jun 7, 2022
715a4a9
Allow minor version updates for prod dependencies (#2117)
dgreif Jun 8, 2022
5eb1b7b
chore(deps): bump @primer/octicons-react from 16.1.1 to 17.3.0 (#2119)
dependabot[bot] Jun 8, 2022
ea1b068
Export NavList from the main bundle (#2112)
colebemis Jun 9, 2022
b4e0812
Fix CI for Node 16.15.1 (#2123)
siddharthkp Jun 17, 2022
857f045
Version Packages (#2097)
primer-css Jun 20, 2022
fd76066
ADR: Parallel drafts track & plan for deprecated components (#1722)
siddharthkp Jun 20, 2022
ab2b958
ADR 004: Strict props or Composite components (#1703)
siddharthkp Jun 20, 2022
f9f8b5a
Fixed an issue with ButtonDanger Not defined. (#2128)
Jun 20, 2022
977eda7
Deprecate SideNav in favor of NavList (#2120)
colebemis Jun 20, 2022
b0745de
Enforce correct semantics for TabNav (#2125)
owenniblock Jun 21, 2022
fb380f7
Adding codeql scanning (#2134)
jonrohan Jun 21, 2022
13d27e8
Navlist passthrough action list group props (#2133)
mattcosta7 Jun 21, 2022
283f575
Explicitly declare workflow permissions for previews (#2137)
rezrah Jun 21, 2022
ecf9b28
Basic SegmentedControl functionality (#2108)
mperrotti Jun 23, 2022
f5131e7
Use import for `focus-visible` instead of require (#2149)
dgreif Jun 27, 2022
de42e1a
CONTRIBUTING.md: Updating typecheck instructions (#2151)
jeffwilcox Jun 28, 2022
3ac5851
Add AutocompleteContext to Autocomplete component exports (#2153)
willglas Jun 28, 2022
86ceeeb
Autocomplete: allow "falsely" input values (#2154)
mperrotti Jun 28, 2022
ba49507
fix: checkbox to useIsomorphicLayoutEffect (#2155)
mperrotti Jun 28, 2022
bba2e4c
Change false to undefined (#2122)
siddharthkp Jun 28, 2022
d29a5b1
Add focusZone to TabNav (#2139)
owenniblock Jun 28, 2022
bc31e5d
ActionMenu: a11y fixes (batch 1) (#2099)
siddharthkp Jun 29, 2022
ab4d40c
ActionMenu: Replace typeahead with mnemonics (#2105)
siddharthkp Jun 29, 2022
8506cfc
Selected tab doesn't need to be <a> tag (#2158)
owenniblock Jun 30, 2022
738d587
AnchoredOverlay: Keep tabIndex for renderAnchor (#2159)
siddharthkp Jun 30, 2022
02767f0
Version Packages (#2131)
primer-css Jun 30, 2022
0d364bb
SplitPageLayout API (#2144)
colebemis Jun 30, 2022
1d82c16
Convert commonjs code to esm during build (#2150)
dgreif Jun 30, 2022
e2685ed
skip transform for storybook (#2177)
siddharthkp Jul 19, 2022
3e8ab89
Correct and improve Storybook and docs for form controls (#2143)
mperrotti Jul 20, 2022
bcee2e6
Bump primer primitives to latest `7.8.4` (#2180)
mattcosta7 Jul 20, 2022
1d263e9
Improves keyboard navigation for the SegmentedControl (#2145)
mperrotti Jul 21, 2022
41533f2
Version Packages (#2161)
primer-css Jul 21, 2022
b403fed
Updated StateLabel to include `issueClosedNotPlanned` and fix `issueC…
anleac Jul 22, 2022
e2f385a
Fix broken focus outline on the Select component (#2173)
mperrotti Jul 25, 2022
c7903d7
SegmentedControl variant prop (#2164)
mperrotti Jul 25, 2022
364a5ec
Use SegmentedControl component primitives (#2186)
mperrotti Jul 25, 2022
00027d0
PageLayout: Implement responsive `hidden` prop (#2174)
colebemis Jul 26, 2022
e906f9f
Button should respect polymorphic as prop (#2166)
mattcosta7 Jul 27, 2022
959e83b
[passion week] Interaction tests with storybook's play function (#2172)
pksjce Jul 27, 2022
80bef41
Codemod for react 18 children types (#2196)
mattcosta7 Jul 27, 2022
12bdb53
Upgrade `user-event` to v14 (#2190)
iansan5653 Jul 28, 2022
8c2beaa
PageLayout: Update `divider` prop responsive API (#2198)
colebemis Jul 29, 2022
ed11f24
docs: NavList example with next/link's URL object (#2203)
wiinci Jul 29, 2022
a7ff271
PageLayout: Update `position` responsive prop API (#2199)
colebemis Jul 29, 2022
2daac91
ActionMenu: Remove focus trap + Fix initial focus (#2024)
siddharthkp Aug 1, 2022
201ffc9
Default ConfirmationDialog to focusing `cancel` when the confirmation…
mattcosta7 Aug 1, 2022
2681253
Merge branch 'main' into fix-typos
PrinceSumberia Aug 1, 2022
8bf391b
Merge branch 'primer:main' into fix-typos
PrinceSumberia Aug 2, 2022
e8f6f25
Merge branch 'main' into fix-typos
PrinceSumberia Aug 2, 2022
ba88741
Merge branch 'main' into fix-typos
siddharthkp Aug 3, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/ActionMenu.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ import {ActionMenu} from '@primer/react'

### With a custom anchor

You can choose to have a different _anchor_ for the Menu dependending on the application's context.
You can choose to have a different _anchor_ for the Menu depending on the application's context.

&nbsp;

Expand Down
2 changes: 1 addition & 1 deletion docs/content/Autocomplete.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ render(<CustomSortAfterMenuClose />)

#### Custom filtering

In this example, we show any items who's `text` **contains** the input value. By default, we only show items that start with the input value.
In this example, we show any items whose `text` **contains** the input value. By default, we only show items that start with the input value.

```javascript live noinline
const CustomSearchFilter = () => {
Expand Down
2 changes: 1 addition & 1 deletion docs/content/Dialog.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ status: Alpha

import State from '../components/State'

The dialog component the Primer implementation of the ARIA design pattern [Dialog](https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal). A dialog is a type of overlay that can be used for confirming actions, asking for disambiguation, and presenting small forms. They generally allow the user to focus on a quick task without having to navigate to a different page.
The dialog component is the Primer implementation of the ARIA design pattern [Dialog](https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal). A dialog is a type of overlay that can be used for confirming actions, asking for disambiguation, and presenting small forms. They generally allow the user to focus on a quick task without having to navigate to a different page.

**Dialogs appear in the page after a direct user interaction**. Don't show dialogs on page load or as system alerts.

Expand Down
2 changes: 1 addition & 1 deletion docs/content/FormControl.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ render(ValidationExample)

### FormControl

The container that handles the layout and passes the relevant IDs and ARIA attributes it's children.
The container that handles the layout and passes the relevant IDs and ARIA attributes its children.

<PropsTable>
<PropsTableRow
Expand Down