Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActionList group roles #1876

Merged
merged 6 commits into from
Feb 23, 2022
Merged

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Feb 21, 2022

Before:

<ul role="none">
  <li>
    <div role="presentation" aria-hidden="true" id="1">Open</div>
    <ul role="menu" aria-labelledby="1">
      <li role="menuitemradio">FY22 - Q3</li>
      <li role="menuitemradio">FY22 - Q2</li>
    </ul>
  </li>
  <li>
    <div role="presentation" aria-hidden="true" id="2">Closed</div>
    <ul role="menu" aria-labelledby="2">
      <li role="menuitemradio">FY22 - Q1</li>
      <li role="menuitemradio">FY21 - Q4</li>
    </ul>
  </li>
</ul>

Accessibility tree:

generic
  generic
    menu "Open"
      menuitemradio "FY22 - Q3"
      menuitemradio "FY22 - Q2"
    menu "Closed"
      menuitemradio "FY22 - Q1"
      menuitemradio "FY21 - Q4"

After:

<ul role="menu">
  <li role="none>
    <div role="presentation" aria-hidden="true" id="1">Open</div>
    <ul role="group" aria-labelledby="1">
      <li role="menuitemradio">FY22 - Q3</li>
      <li role="menuitemradio">FY22 - Q2</li>
    </ul>
  </li>
  <li role="none">
    <div role="presentation" aria-hidden="true" id="2">Closed</div>
    <ul role="group" aria-labelledby="2">
      <li role="menuitemradio">FY22 - Q1</li>
      <li role="menuitemradio">FY21 - Q4</li>
    </ul>
  </li>
</ul>

Accessibility tree:

menu
  group "Open"
    menuitemradio "FY22 - Q3"
    menuitemradio "FY22 - Q2"
  group "Closed"
    menuitemradio "FY22 - Q1"
    menuitemradio "FY21 - Q4"

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2022

🦋 Changeset detected

Latest commit: f98e53e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 62.62 KB (0%)
dist/browser.umd.js 63.01 KB (0%)

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@siddharthkp siddharthkp enabled auto-merge (squash) February 23, 2022 11:38
@siddharthkp siddharthkp merged commit 6cc9260 into main Feb 23, 2022
@siddharthkp siddharthkp deleted the siddharth/actionlist-group-a11y branch February 23, 2022 11:38
@primer-css primer-css mentioned this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants