-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge DropdownMenu2 into ActionMenu2 #1848
Merge DropdownMenu2 into ActionMenu2 #1848
Conversation
🦋 Changeset detectedLatest commit: 5654f8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
This reverts commit 1e90bda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API feels much nicer 💖
Co-authored-by: Cole Bemis <colebemis@github.com>
Update: Whoops, can't delete DropdownMenu2 because memex already uses it: https://cs.github.com/?scopeName=All+repos&scope=&q=primer%2Freact%2Flib-esm%2Fdrafts+DropdownMenu Going to keep that around until the big deprecation: https://github.com/github/primer/issues/716 |
Perfect timing for me to remove from my experiments the DropdownMenu2 and focus building on ActionMenu2. |
@siddharthkp At the end of your loom, you refer to |
Following up on the proposal to simplify components based on ActionList: loom video
Merge checklist