Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DropdownMenu2 into ActionMenu2 #1848

Merged
merged 17 commits into from
Feb 21, 2022

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Feb 9, 2022

Following up on the proposal to simplify components based on ActionList: loom video

- <DropdownMenu>
-   <DropdownMenu.Button>toggle menu</DropdownMenu.Button>
-   <DropdownMenu.Overlay>
       <ActionList>...<ActionList>
-   </DropdownMenu.Overlay>
- <DropdownMenu>

+ <ActionMenu>
+   <ActionMenu.Button>toggle menu</ActionMenu.Button>
+   <ActionMenu.Overlay>
+     <ActionList selectionVariant="single">...<ActionList> // notice the selectionVariant here :)
+   </ActionMenu.Overlay>
+ <ActionMenu>
  • Update components
  • Update docs
  • Update stories
  • Update tests

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@siddharthkp siddharthkp requested review from a team and keithamus February 9, 2022 16:34
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2022

🦋 Changeset detected

Latest commit: 5654f8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp requested review from colebemis and removed request for keithamus February 9, 2022 16:34
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 62.6 KB (0%)
dist/browser.umd.js 62.99 KB (0%)

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API feels much nicer 💖

docs/content/drafts/ActionMenu2.mdx Outdated Show resolved Hide resolved
@siddharthkp
Copy link
Member Author

siddharthkp commented Feb 17, 2022

Update: Whoops, can't delete DropdownMenu2 because memex already uses it: https://cs.github.com/?scopeName=All+repos&scope=&q=primer%2Freact%2Flib-esm%2Fdrafts+DropdownMenu

Going to keep that around until the big deprecation: https://github.com/github/primer/issues/716

@siddharthkp siddharthkp merged commit 96a151a into main Feb 21, 2022
@siddharthkp siddharthkp deleted the siddharth/merge-dropdownmenu-into-actionmenu branch February 21, 2022 11:35
@primer-css primer-css mentioned this pull request Feb 21, 2022
@echarles
Copy link
Contributor

Perfect timing for me to remove from my experiments the DropdownMenu2 and focus building on ActionMenu2.

@echarles
Copy link
Contributor

@siddharthkp At the end of your loom, you refer to NavigationList. I have found this comment that says NavigationList should replace SideNav when ready. What are the plans for that NavigationList? Any way to already try it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants