Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package engines #1840

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Add package engines #1840

merged 4 commits into from
Feb 4, 2022

Conversation

jclem
Copy link
Contributor

@jclem jclem commented Feb 4, 2022

This adds the following to package.json and docs/package.json:

"engines": {
  "node": ">=12",
  "npm": ">=7"
}

Node 12 works with this project and since it's the oldest maintenance LTS version of Node.js, it seems like a reasonable choice.

The docs/package-lock.json has also been updated to v2, now that we're using npm>=7, which uses the newer lock file format.

@jclem jclem requested review from a team and pksjce February 4, 2022 18:49
@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2022

🦋 Changeset detected

Latest commit: 6ef39fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 61.64 KB (0%)
dist/browser.umd.js 62 KB (0%)

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jclem!

@colebemis colebemis enabled auto-merge (squash) February 4, 2022 19:00
@colebemis colebemis merged commit 1c4786c into main Feb 4, 2022
@colebemis colebemis deleted the add-package-engines branch February 4, 2022 19:04
@primer-css primer-css mentioned this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants