ActionMenu2 + DropdownMenu2: Initial focus is based on key used to open menu #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b863987 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
commented
Jan 28, 2022
src/hooks/useMenuFocus.ts
Outdated
| if (['ArrowDown', 'Space', 'Enter'].includes(openingKey)) { | ||
| const firstElement = iterable.next().value | ||
| /** We push imperative focus to the next tick to prevent React's batching */ | ||
| setTimeout(() => firstElement?.focus()) |
There was a problem hiding this comment.
As the comment suggests, we push this to next tick so that the menu has opened.
siddharthkp
changed the title
colebemis
approved these changes
Jan 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Notes for reviewer: Would have been really cool to use
focusInStrategyin@primer/behaviors/focusZonebut unfortunately that only kicks once the focus zone (overlay in this case) is open and initialised; And because of that, it doesn't have the information about the trigger keyboard event. To make that happen, we would need to rewire how AnchoredOverlay works, so that it can attach listeners even when it's closed. I didn't feel super confident about doing that, so create a separate hook that only cares about initial focus.