Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add alternative for deprecated Dropdown #1808

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Docs: Add alternative for deprecated Dropdown #1808

merged 1 commit into from
Jan 19, 2022

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jan 19, 2022 •
edited
Loading

Keeping it simple

Add a link to DropdownMenu

Note: We would update this again at some point this quarter when DropdownMenu v2 comes out of drafts into the main bundle

@siddharthkp siddharthkp added docs Documentation react labels Jan 19, 2022
@siddharthkp siddharthkp self-assigned this Jan 19, 2022
@siddharthkp siddharthkp requested review from a team and mperrotti January 19, 2022 08:20
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2022

⚠️ No Changeset found

Latest commit: d57a757

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp requested review from pksjce and removed request for mperrotti January 19, 2022 08:21
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Jan 19, 2022
@siddharthkp siddharthkp requested review from rezrah and removed request for pksjce January 19, 2022 08:23
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 61.25 KB (0%)
dist/browser.umd.js 61.63 KB (0%)

@siddharthkp siddharthkp mentioned this pull request Jan 19, 2022
Closed
rezrah
rezrah reviewed Jan 19, 2022
View reviewed changes
docs/content/deprecated/Dropdown.md
@@ -3,6 +3,12 @@ title: Dropdown
status: Deprecated
---

## Deprecation

Use [DropdownMenu](/DropdownMenu) instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 . Just for clarity, can we add the import statement to the top of DropdownMenu page? It could be a bit confusing for first-time readers otherwise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the DropdownMenu page is a kind of pretty bare 😅

@siddharthkp siddharthkp merged commit 2febaea into main Jan 19, 2022
@siddharthkp siddharthkp deleted the siddharth/docs-add-alternative-for-deprecated-dropdown branch January 19, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezrah rezrah rezrah approved these changes

Assignees

@siddharthkp siddharthkp

Labels
docs Documentation react skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: component is deprecated with no link to a recommended alternative
2 participants
@siddharthkp @rezrah