Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: disable visual testing #1786

Closed
wants to merge 4 commits into from
Closed

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jan 11, 2022

Remove visual testing action till our limit is reset more context on slack.

To enable it again, we can revert this PR :)

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2022

⚠️ No Changeset found

Latest commit: 8d3c033

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp temporarily deployed to visual-testing January 11, 2022 13:28 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 61.25 KB (0%)
dist/browser.umd.js 61.63 KB (0%)

@siddharthkp siddharthkp self-assigned this Jan 11, 2022
@siddharthkp siddharthkp marked this pull request as ready for review January 11, 2022 13:35
@siddharthkp siddharthkp requested a review from a team January 11, 2022 13:35
@siddharthkp siddharthkp changed the title Skip visual testing CI: skip visual testing Jan 11, 2022
@siddharthkp siddharthkp changed the title CI: skip visual testing CI: disable visual testing Jan 11, 2022
@rezrah
Copy link
Contributor

rezrah commented Jan 13, 2022

To make it easier to renable this without a code change in future, can we keep the workflow in repo and disable it via click-ops instead? https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow

@siddharthkp
Copy link
Member Author

siddharthkp commented Jan 14, 2022

That's cool too! We don't need this PR :)

Note for future: Enable this action from this link - https://github.com/primer/react/actions/workflows/visual_testing.yml

@joshblack joshblack deleted the siddharth/disable-visual-testing branch January 19, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants