Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update storybook dep and fix avatarstack story example #1755

Merged
merged 5 commits into from
Jan 11, 2022
Merged

chore: update storybook dep and fix avatarstack story example #1755

merged 5 commits into from
Jan 11, 2022

Conversation

rezrah
Copy link
Contributor

@rezrah rezrah commented Dec 21, 2021

  • Adds correct usage example to AvatarStack story
    • Replaces img usage with Avatar children
  • Bumped Storybook versions to latest

Follow-up to #1751

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@rezrah rezrah added the skip changeset This change does not need a changelog label Dec 21, 2021
@rezrah rezrah requested review from a team and siddharthkp December 21, 2021 15:41
@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9681ab0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rezrah rezrah temporarily deployed to visual-testing January 10, 2022 17:56 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 59.94 KB (0%)
dist/browser.umd.js 60.3 KB (0%)

@rezrah rezrah temporarily deployed to visual-testing January 11, 2022 10:10 Inactive
@rezrah rezrah temporarily deployed to visual-testing January 11, 2022 10:41 Inactive
@rezrah rezrah merged commit cab63c0 into main Jan 11, 2022
@rezrah rezrah deleted the chore/storybook-update-and-avatarstack-fix branch January 11, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rezrah @siddharthkp