Skip to content

Select Input react component #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Select Input react component #1731

wants to merge 1 commit into from

Conversation

pksjce
Copy link
Contributor

@pksjce pksjce commented Dec 14, 2021

Describe your changes here.

This is one of the components implemented for the form components epic.
Things to do

  • Style the carets properly
  • Optgroup component
  • discuss textinput wrapper height
  • Add doc

Closes https://github.com/github/primer/issues/539

Screenshots

TBD

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@pksjce pksjce requested review from a team and colebemis December 14, 2021 10:30
@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2021

⚠️ No Changeset found

Latest commit: 1b1a6f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pksjce pksjce marked this pull request as draft December 14, 2021 10:30
@pksjce pksjce requested review from mperrotti and rezrah December 14, 2021 10:30
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 57.26 KB (0%)
dist/browser.umd.js 57.59 KB (0%)

@pksjce pksjce mentioned this pull request Dec 15, 2021
6 tasks
@pksjce pksjce closed this Dec 15, 2021
@pksjce
Copy link
Contributor Author

pksjce commented Dec 15, 2021

Duplicate of #1736

@pksjce pksjce marked this as a duplicate of #1736 Dec 15, 2021
@joshblack joshblack deleted the pk/select-input branch January 19, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant