Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add deprecation section on Dialog to use Dialog2 #1714

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Docs: Add deprecation section on Dialog to use Dialog2 #1714

merged 4 commits into from
Dec 16, 2021

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Dec 10, 2021 •
edited
Loading

Add a note on deprecated Dialog docs to use Dialog 2 which replaced it - in the style of BorderBox and Flex

Screenshots

image

Merge checklist

  • Added/updated documentation

@siddharthkp siddharthkp added docs Documentation react skip changeset This change does not need a changelog labels Dec 10, 2021
@siddharthkp siddharthkp self-assigned this Dec 10, 2021
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: a6197bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp marked this pull request as ready for review December 10, 2021 10:39
@siddharthkp siddharthkp requested review from a team and colebemis December 10, 2021 10:39
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2021 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 57.5 KB (0%)
dist/browser.umd.js 57.8 KB (0%)

@siddharthkp siddharthkp changed the title Deprecated Dialog: Add note to use Dialog2 Docs: Add deprecation section on Dialog to use Dialog2 Dec 10, 2021
@colebemis colebemis enabled auto-merge (squash) December 16, 2021 22:02
@colebemis colebemis merged commit fa6c311 into main Dec 16, 2021
@colebemis colebemis deleted the siddharth/dialog-deprecated-alternative branch December 16, 2021 22:07
pksjce pushed a commit that referenced this pull request Dec 20, 2021
@siddharthkp @colebemis @pksjce
Add deprecation block in docs (#1714)
35ac2d8 
Co-authored-by: Cole Bemis <colebemis@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@colebemis colebemis Awaiting requested review from colebemis

Assignees

@siddharthkp siddharthkp

Labels
docs Documentation react skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddharthkp @mperrotti @colebemis