Skip to content

Release Tracking #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Release Tracking #1707

merged 1 commit into from
Dec 16, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 8, 2021

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@34.0.1

Patch Changes

@github-actions github-actions bot requested review from a team and rezrah December 8, 2021 21:57
@github-actions github-actions bot force-pushed the changeset-release/main branch 4 times, most recently from d37c31e to a28dd93 Compare December 10, 2021 14:01
@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 10, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 57.5 KB (0%)
dist/browser.umd.js 57.8 KB (0%)

@colebemis
Copy link
Contributor

🛑 Do not merge yet. Extracting the behaviors code into a separate package (@primer/behaviors) broke some imports in Memex

ERROR in src/client/components/collaborator-role-drop-down.tsx:2:25
TS2307: Cannot find module '@primer/react/lib-esm/behaviors/focusZone' or its corresponding type declarations.
    1 | import {Box, Button, Dropdown, SelectMenu, Text} from '@primer/react'
  > 2 | import {FocusKeys} from '@primer/react/lib-esm/behaviors/focusZone'
      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    3 | import {useFocusTrap} from '@primer/react/lib-esm/hooks/useFocusTrap'
    4 | import {useFocusZone} from '@primer/react/lib-esm/hooks/useFocusZone'
    5 | import {Permission} from 'api/common-contracts'

@dgreif will open a PR to fix this soon

@colebemis
Copy link
Contributor

@dgreif merged a PR to re-export FocusKeys and Direction from lib/useFocusZone

To upgrade, Memex will need to update their imports accordingly:

- import {FocusKeys} from '@primer/react/lib-esm/behaviors/focusZone'
+ import {FocusKeys} from '@primer/react/lib-esm/hooks/useFocusZone'

- import {Direction} from '@primer/react/lib-esm/behaviors/focusZone'
+ import type {Direction} from '@primer/react/lib-esm/hooks/useFocusZone'

We are not considering this a breaking change because the behaviors are still in "alpha" and not included in the main bundle.

@colebemis colebemis merged commit 8157478 into main Dec 16, 2021
@colebemis colebemis deleted the changeset-release/main branch December 16, 2021 01:18
pksjce pushed a commit that referenced this pull request Dec 20, 2021
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant