Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a component to support checkbox and radio groups #1657

Merged
merged 119 commits into from
Jan 11, 2022
Merged

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Nov 24, 2021

Adds a component to show a set of related checkbox or radio inputs

Closes https://github.com/github/primer/issues/496

Screenshots

selectionVariant="single" (default)

Screen Shot 2021-12-03 at 3 58 21 PM

selectionVariant="multiple"

Screen Shot 2021-12-03 at 3 57 57 PM

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Note: I intentionally excluded this animation for the ChoiceFieldset because it has nowhere to animate in from
Base automatically changed from mp/form-field-component to main December 17, 2021 19:28
@mperrotti mperrotti temporarily deployed to visual-testing January 11, 2022 15:52 Inactive
@mperrotti mperrotti merged commit d143c95 into main Jan 11, 2022
@mperrotti mperrotti deleted the mp/choice-group branch January 11, 2022 16:17
@primer-css primer-css mentioned this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants