-
Notifications
You must be signed in to change notification settings - Fork 616
Create ComponentChecklist
component
#1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! No changes needed here, suggested changes in doctocat.
@siddharthkp @jfuchs Is this |
It's very clear. Bonus: now we make it pretty too 😋 I like the skip icon you had from octions! How do you feel about adding N/A to the text part? |
Love it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool @colebemis. As a name suggestion, how about "Component status", as provides more detailed explanation - and is directly related to - the status at the top of the page? Edit: NVM, you've updated it to this already, didn't see your updated screenshot 🥳
Adds a
ComponentChecklist
component in the/docs
directory that will enable us to document the maturity of our components.Known issues
Here are list of known issues with
ComponentChecklist
that I think are out of scope for this PR:ComponentChecklist
component needs to be imported in every markdown file that uses it. I plan to make a change in Doctocat that will allow us to makeComponentChecklist
globally available in all markdown files. Until I make that change,ComponentChecklist
will need to be explicitly imported.ComponentChecklist
items are hard to guess. You'll need to look at the definition ofComponentChecklist
to know which checklist items to pass. I imagine most people will useComponentChecklist
by copying and pasting from other documentation pages, so I don't think this is a dealbreaker## Component checklist
) needs to be written directly in the.md
or.mdx
file. The heading can't be included in theComponentChecklist
component because it won't be listed in the table of contents.Open questions
Component checklist
for now but I'm open to other ideas.n/a
state for a checklist item visually clear? I'm using the same icon that we use to represent a "skipped" GitHub action.Next steps
Notes
This is a departure from my original implementation plan for component checklists. I wrote about why changed my implementation plan here.