Skip to content

ActionList: Add keyboard accessibility #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 123 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 10, 2021

Change base after #1517 is merged
Part of https://github.com/github/primer/issues/447
Includes visual changes for keyboard focus from https://github.com/github/primer/issues/409

Please provide before/after screenshots for any visual changes

before:

tab.tab.fail.mov

after:

tabtab.mov

Merge checklist

  • Added/updated tests
  • NA Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2021

🦋 Changeset detected

Latest commit: 5843ae1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 54.42 KB (0%)
dist/browser.umd.js 54.81 KB (0%)

Base automatically changed from action-list-2 to main November 11, 2021 13:32
@siddharthkp
Copy link
Member Author

Replaced with #1603

@joshblack joshblack deleted the siddharth/actionlist-keyboard-a11y branch January 19, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants