Skip to content

ActionList: Better label & description for Item #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 114 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 8, 2021

Change base after #1517 is merged
Part of https://github.com/github/primer/issues/447

  • Bring inline description to be part of label.
  • Block description is describedby

This is the generated HTML, formatted for legibility:

image

<ul>
  <li aria-labelledby="react-aria-1 react-aria-2">
    <span><img src="https://github.com/pksjce.png"/></span>
    <div data-component="ActionList.Item--DividerContainer">
      <div>
        <span id="react-aria-1">pksjce</span>
        <div id="react-aria-2" title="Pavithra Kodmad">Pavithra Kodmad</div>
      </div>
    </div>
  </li>
  <li>...</li>
  <li role="separator"></li>
  <li aria-labelledby="react-aria-3 " aria-describedby="react-aria-4">
    <span><span class="label-circle"></span></span>
    <div data-component="ActionList.Item--DividerContainer">
      <span id="react-aria-3">blocked</span>
      <span id="react-aria-4">
        Someone or something is preventing this from moving forward
      </span>
    </div>
  </li>
  <li>...</li>
</ul>

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2021

🦋 Changeset detected

Latest commit: 08e944c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp changed the title bring inline description to label ActionList: Better label & description for Item Nov 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 54.42 KB (0%)
dist/browser.umd.js 54.81 KB (0%)

@siddharthkp siddharthkp self-assigned this Nov 8, 2021
Base automatically changed from action-list-2 to main November 11, 2021 13:32
@siddharthkp
Copy link
Member Author

Moved to #1599

@joshblack joshblack deleted the siddharth/action-list-description-a11y branch January 19, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants