Skip to content

Fix auxiliaryText in ActionList/Header.tsx #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

michael-lefebvre
Copy link
Contributor

the auxiliaryText property are not displayed due to missing curly braces

Describe your changes here.

Closes # (type the issue number after # if applicable; otherwise remove this line)

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

the auxiliaryText property are not displayed due to missing curly braces
@michael-lefebvre michael-lefebvre requested review from a team and rezrah November 1, 2021 16:17
@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2021

🦋 Changeset detected

Latest commit: 5a3d5f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! You can tell auxiliaryText isn't very popular 😄

@siddharthkp siddharthkp merged commit f565840 into primer:main Nov 1, 2021
@primer-css primer-css mentioned this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants