Skip to content

Conversation

@jfuchs
Copy link
Contributor

@jfuchs jfuchs commented Sep 14, 2021

While figuring out some TS issues I ran into this one place where we have styling defined via the CSS prop.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jfuchs jfuchs requested a review from a team September 14, 2021 19:16
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2021

🦋 Changeset detected

Latest commit: 6fba113

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 48.74 KB (-0.21% 🔽)
dist/browser.umd.js 49.03 KB (-0.21% 🔽)

@colebemis colebemis enabled auto-merge (squash) September 15, 2021 20:38
@colebemis colebemis merged commit 7cf8d8b into main Sep 15, 2021
@colebemis colebemis deleted the jfuchs/timeline-idiosyncracy branch September 15, 2021 20:41
@primer-css primer-css mentioned this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants