Migrate to new functional color system #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be6d684 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
commented
Sep 15, 2021
2 tasks
jfuchs
approved these changes
Sep 16, 2021
|
@jfuchs We don't have a suitable replacement |
|
@jonrohan What do you think we should replace |
colebemis
force-pushed
the
new-colors
branch
from
2053c0f
to
30e5c3a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
An recent release of Primer Primitives deprecated many existing color variables and introduced new functional color variables.
Problem
Primer React components is using deprecated functional color variables.
Solution
@primer/primitivesversion so we can use the new functional color variableseslint-plugin-primer-reactto lint for usages of deprecated color variablesPart of https://github.com/github/design-infrastructure/issues/1388