Use @react-aria/ssr for isomorphic ID generation. #1409
Conversation
🦋 Changeset detectedLatest commit: 841ad7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
per adobe/react-spectrum#2278 (comment), we might get a release early next week. |
jfuchs
force-pushed
the
jfuchs/react-aria-ssr
branch
from
9ab697b to
364806c
Compare
jfuchs
force-pushed
the
jfuchs/react-aria-ssr
branch
from
e31b323 to
838b035
Compare
| @@ -0,0 +1,37 @@ | |||
| --- | |||
| title: Server-side rendering with Primer React | |||
There was a problem hiding this comment.
Thank you for writing docs! 💖
There was a problem hiding this comment.
Can you add this doc to the side nav? https://github.com/primer/react/blob/main/docs/src/%40primer/gatsby-theme-doctocat/nav.yml
| // Note: uniqueId may be unsafe in SSR contexts if it is used create DOM IDs or otherwise cause a hydration warning. Use useSSRSafeId instead. | ||
|
|
||
| let idSeed = 10000 | ||
| export function uniqueId(): string { |
There was a problem hiding this comment.
Is uniqueId still useful if we have useSSRSafeId?
There was a problem hiding this comment.
There's one place where it's still used — the useFocusZone behavior. I believe it's safe because it's only called downstream of a user interaction. As far as I can tell, we'd need to do a decent refactoring or just require that IDs are already in place to get rid of it.
colebemis
left a comment
colebemis
left a comment
There was a problem hiding this comment.
Looks great! Just left a few minor comments.
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Closes #1392
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.