Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose textInputProps from SelectPanel #1311

Merged
merged 5 commits into from
Jun 17, 2021
Merged

Expose textInputProps from SelectPanel #1311

merged 5 commits into from
Jun 17, 2021

Conversation

lukewar
Copy link
Contributor

@lukewar lukewar commented Jun 16, 2021

Description

Adding option to pass textInputProps. This allows customizing the input field.

Screenshots

Before After
before after

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2021

🦋 Changeset detected

Latest commit: 8327bc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/DSyneZFcPjxw79fcvWm4BCSXqhHE
✅ Preview: https://primer-components-git-fork-lukewar-main-primer.vercel.app

src/SelectPanel/SelectPanel.tsx Outdated Show resolved Hide resolved
src/SelectPanel/SelectPanel.tsx Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview June 17, 2021 08:45 Inactive
Copy link
Member

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution!

@vercel vercel bot temporarily deployed to Preview June 17, 2021 14:38 Inactive
@dgreif dgreif enabled auto-merge (squash) June 17, 2021 14:38
@dgreif dgreif merged commit 6f0535d into primer:main Jun 17, 2021
@github-actions github-actions bot mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants