docs: Add a story demoing height-after-fetch #1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1287. From that PR’s description:
This PR adds a story demonstrating this pattern.
https://github.com/github/primer/issues/161 described two cases:
SelectPanel
whoseItem
s are known during the initial renderSelectPanel
whoseItem
s are asynchronously fetchedThis story demonstrates that the
Overlay
component supports content-matched height in both cases (regardless of whether the content is initially available or fetched), so https://github.com/github/primer/issues/161 can considered addressed. Fixes https://github.com/github/primer/issues/161.Screen recording
Merge checklist