Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export composable pieces of List/Item #1280

Merged
merged 6 commits into from
Jun 9, 2021

Conversation

VanAnderson
Copy link
Contributor

@VanAnderson VanAnderson commented Jun 9, 2021

Exporting the TextContainer here will allow us to use this as a composable piece when utilizing the children of ActionList/Item

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2021

🦋 Changeset detected

Latest commit: 7c5b1c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/7wt6niN1JKYDM2UGAo1xhshnu6XC
✅ Preview: https://primer-compone-git-vananderson-composable-children-list-31489a.vercel.app

@vercel vercel bot temporarily deployed to Preview June 9, 2021 15:06 Inactive
src/ActionList/Item.tsx Outdated Show resolved Hide resolved
Co-authored-by: Clay Miller <clay@smockle.com>
@vercel vercel bot temporarily deployed to Preview June 9, 2021 15:31 Inactive
@vercel vercel bot temporarily deployed to Preview June 9, 2021 15:45 Inactive
@vercel vercel bot temporarily deployed to Preview June 9, 2021 15:54 Inactive
@VanAnderson VanAnderson marked this pull request as ready for review June 9, 2021 16:16
Copy link
Member

@smockle smockle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for the quick turnaround on this! 🚀

@VanAnderson VanAnderson merged commit f793ed0 into main Jun 9, 2021
@VanAnderson VanAnderson deleted the VanAnderson/composable-children-list-item branch June 9, 2021 18:22
@github-actions github-actions bot mentioned this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants