Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hide intra-'Item' dividers on ':hover' and ':focus' #1259

Merged
merged 3 commits into from
May 28, 2021
Merged

fix: Hide intra-'Item' dividers on ':hover' and ':focus' #1259

merged 3 commits into from
May 28, 2021

Conversation

smockle
Copy link
Member

@smockle smockle commented May 27, 2021

Fixes https://github.com/github/primer/issues/180

Screenshots

:hover
Screen recording of disappearing dividers when 'Item's are hovered

:focus
Screen recording of disappearing dividers when 'Item's are focused

All ActionList stories
Screen recording of disappearing dividers in every 'ActionList' story

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 2c243dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 27, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/EvGG2Lbbzi1b2mb7QX8icPxqdqiv
✅ Preview: https://primer-components-git-hide-dividers-primer.vercel.app

colebemis
colebemis approved these changes May 27, 2021
View reviewed changes
src/ActionList/Item.tsx Show resolved Hide resolved
dgreif
dgreif approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing out these styles! I think this will feel way more natural

@vercel vercel bot temporarily deployed to Preview May 27, 2021 21:58 Inactive
@vdepizzol
Copy link
Contributor

vdepizzol commented May 28, 2021 •
edited
Loading

❤ ❤ ❤

@vercel vercel bot temporarily deployed to Preview May 28, 2021 19:47 Inactive
@smockle smockle merged commit 1585064 into main May 28, 2021
@smockle smockle deleted the hide-dividers branch May 28, 2021 19:51
@github-actions github-actions bot mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@dgreif dgreif dgreif approved these changes

@vdepizzol vdepizzol vdepizzol approved these changes

@bscofield bscofield Awaiting requested review from bscofield

@VanAnderson VanAnderson Awaiting requested review from VanAnderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smockle @vdepizzol @dgreif @colebemis