Action Menu correctly fires onAction callback after close #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bdedc4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/CgEuBA2jHhzNgEuNeTNUbvxmpe78 |
dgreif
approved these changes
May 14, 2021
| "@primer/components": patch | ||
| --- | ||
|
|
||
| Action Menu correctly fires onAction callback after close. |
There was a problem hiding this comment.
Might want to update these release notes to reflect the fact that it will be called before close now
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small fixes here that seem to be possibly from a botched rebase!
The after close behavior wasn't working quite as it should have been, because the
useEffecthook had the wrong dependency (open vs combinedOpenState for the work to make ActionMenu optionally controlled) - further, the onAction callback was firing twice in the code when the component was operating as a controlled component due to both thependingActionRefbeing populated and the call on L82.