Action Menu can have its open state be controlled externally #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b38f743 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/EeBKGKjYK7BXoiEqFzM5k9saA5Zn |
VanAnderson
changed the title
dgreif
requested changes
Apr 30, 2021
VanAnderson
force-pushed
the
VanAnderson/action-menu-external-open
branch
from
c35d42d
to
6f6d56b
Compare
dgreif
reviewed
May 3, 2021
dgreif
reviewed
May 3, 2021
Co-authored-by: Dusty Greif <dgreif@users.noreply.github.com>
dgreif
approved these changes
May 4, 2021
Merged
This was referenced Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small API change to optionally accept
openandsetOpen- if these props are present then the open/closed state of ActionMenu will be externally controlled.Fixes https://github.com/github/primer/issues/135